NO-ISSUE: Update github.com/openshift/api digest to 94aed51#852
NO-ISSUE: Update github.com/openshift/api digest to 94aed51#852red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
openshift-ci-robot
added
the
jira/valid-reference
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api/go.mod`:
- Line 6: The require line for the module symbol "github.com/openshift/api"
currently uses a bare commit hash (c73917c76a14) which is invalid; replace that
entry with a valid semantic version or a Go pseudo-version for that commit (or
run "go get github.com/openshift/api@c73917c76a14" to let Go generate the
correct pseudo-version), then run "go mod tidy" to update go.mod/go.sum so
dependency resolution succeeds.
api/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/openshift/api v0.0.0-20240830023148-b7d0481c9094 | ||
| github.com/openshift/api c73917c76a14 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify the openshift/api require version in api/go.mod matches semver or pseudo-version.
line="$(rg -nP '^\s*github\.com/openshift/api\s+\S+' api/go.mod)"
echo "Found: $line"
version="$(awk '/^\s*github\.com\/openshift\/api\s+/ {print $2}' api/go.mod)"
echo "Parsed version: $version"
# Accept semver tags (vX.Y.Z...) or Go pseudo-version (vX.Y.Z-yyyymmddhhmmss-abcdefabcdef)
if [[ "$version" =~ ^v[0-9]+\.[0-9]+\.[0-9]+([-.].*)?$ ]] || [[ "$version" =~ ^v[0-9]+\.[0-9]+\.[0-9]+-[0-9]{14}-[0-9a-f]{12}$ ]]; then
echo "OK: version format is valid."
else
echo "FAIL: version format is invalid for go.mod require directive."
exit 1
fiRepository: openshift/cluster-api-provider-agent
Length of output: 218
🏁 Script executed:
#!/bin/bash
# Read the api/go.mod file to see the context around line 6
echo "=== Content of api/go.mod with context ==="
cat -n api/go.mod | sed -n '1,15p'
echo -e "\n=== Check if this is within a require block ==="
head -20 api/go.modRepository: openshift/cluster-api-provider-agent
Length of output: 1267
🌐 Web query:
Go module require directive version format specification
💡 Result:
In a go.mod file, a require directive has the form:
require module/path vX.Y.ZVersion format rules (what’s allowed after the module path):
- Must be a canonical module version: it starts with
vand is a Semantic Versioning 2.0.0 string:vMAJOR.MINOR.PATCH, optionally with pre-release (-...) and/or build metadata (+...). Examples:v1.2.3,v1.2.3-rc.1,v2.0.9+meta. [1] - Major version must match the module path’s major suffix (Semantic Import Versioning):
- For v0/v1, the module path is typically
example.com/mod. - For v2+, the module path must end in
/vNand the required version must bevN.x.y, e.g.require example.com/mod/v2 v2.3.4. [2][3]
- For v0/v1, the module path is typically
- Pseudo-versions are allowed (generated by Go tools for untagged commits). Canonical forms include:
vX.0.0-yyyymmddhhmmss-abcdefabcdef(no base tag)vX.Y.(Z+1)-0.yyyymmddhhmmss-abcdefabcdef(based on a prior tag) [1]
(Also described asbaseVersionPrefix-timestamp-revisionIdentifier.) [2]
+incompatiblemay appear when a repo has semver tags (often v2+) but does not have ago.modat the repo root; Go may record versions likev4.1.2+incompatible(and it can also appear on pseudo-versions). [1]
What require does not support: version ranges/constraints like ^1.2, >=1.2, etc.—it records a specific minimum version, and the go command resolves the final build list via minimal version selection. [1]
Replace bare commit hash with valid Go module version
Line 6 uses a raw commit hash c73917c76a14, which violates Go module require syntax. Module versions must use semantic versioning or Go's pseudo-version format. This will break dependency resolution.
Proposed fix
- github.com/openshift/api c73917c76a14
+ github.com/openshift/api v0.0.0-<yyyymmddhhmmss>-c73917c76a14🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/go.mod` at line 6, The require line for the module symbol
"github.com/openshift/api" currently uses a bare commit hash (c73917c76a14)
which is invalid; replace that entry with a valid semantic version or a Go
pseudo-version for that commit (or run "go get
github.com/openshift/api@c73917c76a14" to let Go generate the correct
pseudo-version), then run "go mod tidy" to update go.mod/go.sum so dependency
resolution succeeds.
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
from
7220553 to
e8c0051
Compare
red-hat-konflux
bot
changed the title
red-hat-konflux
bot
changed the title
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
2 times, most recently
from
56c1339 to
3dd9528
Compare
red-hat-konflux
bot
changed the title
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
from
3dd9528 to
9dd72aa
Compare
red-hat-konflux
bot
changed the title
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
from
9dd72aa to
8de3cf5
Compare
red-hat-konflux
bot
changed the title
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
from
8de3cf5 to
905119a
Compare
red-hat-konflux
bot
changed the title
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
bot
force-pushed
the
konflux/mintmaker/master/github.com-openshift-api-digest
branch
from
905119a to
7ea3ad6
Compare
red-hat-konflux
bot
changed the title
1 participant
This PR contains the following updates:
b7d0481->94aed51Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.