manager: use per cloud limits for MCE#605
Conversation
Set a limit of 10 clusters for AWS and 10 clusters for GCP instead of using a single 15 cluster limit for MCE.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughReplaced unified global MCE cluster limit with platform-specific limits for AWS (10) and GCP (10). Updated CreateMceCluster logic to count active clusters separately per platform and enforce independent admission checks. Added helper functions to determine cluster platform via labels or ClusterDeployment specification. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can generate walkthrough in a markdown collapsible section to save space.Enable the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexNPavel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@AlexNPavel: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Set a limit of 10 clusters for AWS and 10 clusters for GCP instead of using a single 15 cluster limit for MCE.