Skip to content

manager: use per cloud limits for MCE#605

Open
AlexNPavel wants to merge 1 commit intoopenshift:mainfrom
AlexNPavel:limit-aws-mce
Open

manager: use per cloud limits for MCE#605
AlexNPavel wants to merge 1 commit intoopenshift:mainfrom
AlexNPavel:limit-aws-mce

Conversation

@AlexNPavel
Copy link
Contributor

Set a limit of 10 clusters for AWS and 10 clusters for GCP instead of using a single 15 cluster limit for MCE.

Set a limit of 10 clusters for AWS and 10 clusters for GCP instead of using a
single 15 cluster limit for MCE.
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4b11ac5d-cdda-4840-abfc-db691b9c88da

📥 Commits

Reviewing files that changed from the base of the PR and between 9504e68 and 88a143d.

📒 Files selected for processing (2)
  • pkg/manager/manager.go
  • pkg/manager/mce.go

Walkthrough

Replaced unified global MCE cluster limit with platform-specific limits for AWS (10) and GCP (10). Updated CreateMceCluster logic to count active clusters separately per platform and enforce independent admission checks. Added helper functions to determine cluster platform via labels or ClusterDeployment specification.

Changes

Cohort / File(s) Summary
Platform-Specific MCE Cluster Limits
pkg/manager/manager.go, pkg/manager/mce.go
Replaced single global limit (maxTotalMCEClusters=15) with platform-specific AWS (10) and GCP (10) limits. Updated CreateMceCluster to count active clusters per platform separately and enforce independent admission checks with platform-directed error messages. Added mceClusterIsAWS and mceClusterIsGCP helper functions that determine platform via ManagedCluster labels (Cloud field) or ClusterDeployment.Spec.Platform fields, with fallback handling for custom image builds.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting to generate walkthrough in a markdown collapsible section.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

@AlexNPavel: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant