NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867
NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
In CI, for agent-based installations the environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is set and this is passed down to assisted-service. When doing local testing we also need to set this environment variable.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # Disable image policy verification for local development | ||
| # In CI, this is set via the test configuration (see https://github.com/openshift/installer/pull/10379) | ||
| if [ "${OPENSHIFT_CI}" != "true" ]; then | ||
| export OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY="true" |
There was a problem hiding this comment.
This does not seem correct for all the situation. In particular for the release jobs (or nightly) we want to test a signed payload, isn't it? (I mean locally)
3 participants
In CI, for agent-based installations the environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is set and this is passed down to assisted-service. When doing local testing we also need to set this environment variable.