Use set -euxo pipefail in 01_install_requirements#1866
Use set -euxo pipefail in 01_install_requirements#1866elfosardo wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
elfosardo
force-pushed
the
euxo-pipefail-01
branch
3 times, most recently
from
3381047 to
6110afc
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
elfosardo
force-pushed
the
euxo-pipefail-01
branch
from
6110afc to
abcacef
Compare
|
/cc @tdomnesc |
Replace set -ex with set -euxo pipefail for consistency with 02_configure_host.sh and 04_setup_ironic.sh. Guard optional environment variables with :- defaults to avoid nounset errors and fix a $ARCH typo that should be $GOARCH. Also fix common.sh to handle the case where Go is not yet installed when sourced by 01_install_requirements.sh — skip 'go env' and GOPATH-dependent assignments when the go binary is absent.
elfosardo
force-pushed
the
euxo-pipefail-01
branch
from
abcacef to
78fe138
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@elfosardo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Replace set -ex with set -euxo pipefail for consistency with
02_configure_host.sh and 04_setup_ironic.sh.
Guard optional environment variables with :- defaults to avoid
nounset errors and fix a $ARCH typo that should be $GOARCH.
Also fix common.sh to handle the case where Go is not yet installed
when sourced by 01_install_requirements.sh — skip 'go env' if the
go binary is absent and default GOPATH to empty.