Skip to content

NO-JIRA: feat: add version check for sno req and add sno e2e config#1858

Open
eggfoobar wants to merge 1 commit intoopenshift-metal3:masterfrom
eggfoobar:add-version-check-for-snomin
Open

NO-JIRA: feat: add version check for sno req and add sno e2e config#1858
eggfoobar wants to merge 1 commit intoopenshift-metal3:masterfrom
eggfoobar:add-version-check-for-snomin

Conversation

@eggfoobar
Copy link
Contributor

SNOMIN 4vCPU SNO in ABI will only be changed in 4.22 and above, so older versions will not pass validation
adding check to fail early

@eggfoobar
Copy link
Contributor Author

/assign @andfasano

@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar eggfoobar force-pushed the add-version-check-for-snomin branch 3 times, most recently from 473573f to 7672a42 Compare March 9, 2026 17:27
@eggfoobar eggfoobar changed the title NO-JIRA: feat: add version check for snomin NO-JIRA: feat: add version check for sno req and add sno e2e config Mar 10, 2026
SNO ABI flow will support min 4vCPU in 4.22 and above, so older versions will not pass validation
adding check to fail early

Added validation to SNOMIN for 4.22 and above

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the add-version-check-for-snomin branch from 7672a42 to 3fb8352 Compare March 12, 2026 18:18
@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2026
@eggfoobar
Copy link
Contributor Author

/retest-required

@andfasano
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 3fb8352 link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack 3fb8352 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-ipv6 3fb8352 link unknown /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants