NO-JIRA: feat: add version check for sno req and add sno e2e config#1858
NO-JIRA: feat: add version check for sno req and add sno e2e config#1858eggfoobar wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
/assign @andfasano |
|
/retest-required |
473573f to
7672a42
Compare
SNO ABI flow will support min 4vCPU in 4.22 and above, so older versions will not pass validation adding check to fail early Added validation to SNOMIN for 4.22 and above Signed-off-by: ehila <ehila@redhat.com>
7672a42 to
3fb8352
Compare
|
/lgtm |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
SNOMIN 4vCPU SNO in ABI will only be changed in 4.22 and above, so older versions will not pass validation
adding check to fail early