Add profiling support to unified query API#5268
Draft
dai-chen wants to merge 3 commits intoopensearch-project:mainfrom
Draft
Add profiling support to unified query API#5268dai-chen wants to merge 3 commits intoopensearch-project:mainfrom
dai-chen wants to merge 3 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
Failed to generate code suggestions for PR |
Add TRANSPILE metric for profiling query transpilation in the unified query API, used when converting logical plans to target SQL dialects. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
c85370d to
a4ea219
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
a4ea219 to
6749914
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
6749914 to
2f645f3
Compare
Contributor
|
Failed to generate code suggestions for PR |
Enable profiling in unified query components via UnifiedQueryContext: - profiling(boolean) builder to activate/deactivate profiling - measure(name, callable) API for user-profiled phases (execute, format) - getProfile() to retrieve QueryProfile snapshot after execution - Auto-profiling in UnifiedQueryPlanner (ANALYZE), UnifiedQueryCompiler (OPTIMIZE), and UnifiedQueryTranspiler (TRANSPILE) - All components use context.measure() internally for consistency - NoopProfileContext ensures zero overhead when profiling is disabled Signed-off-by: Chen Dai <daichen@amazon.com>
Extract common test schema and utilities into UnifiedQueryTestBase to reduce duplication across unified query test classes. Profiling tests now extend this base and override buildContext() to enable profiling. Change all timing assertions from > 0 to >= 0 to prevent flakiness. Millisecond-resolution timers can return 0 for fast operations when System.currentTimeMillis() samples the same tick before and after. The >= 0 assertion still validates the metric was recorded (phase key exists in the profile map) without depending on wall-clock granularity. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
2f645f3 to
4a1cbef
Compare
Contributor
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables profiling capability in the unified query API so external consumers (OpenSearch, Spark, CLI) can collect per-phase timing metrics without depending on the REST-specific
QueryContextMDC layer.Key design decisions:
profile=truein REST API, but hide internal profiling abstraction behindUnifiedQueryContext.measure()API outside: Each unified query component auto-profiles its phase and provide measure API for code outside unified query components, e.g., PreparedStatement.executeQuery(), response formatting.Related Issues
Resolves #5248 (partially)
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.