Skip to content

Upgrade Marcel Wolbers to author#555

Open
luwidmer wants to merge 2 commits intomainfrom
547-marcel-author-bump
Open

Upgrade Marcel Wolbers to author#555
luwidmer wants to merge 2 commits intomainfrom
547-marcel-author-bump

Conversation

@luwidmer
Copy link
Collaborator

@luwidmer luwidmer commented Mar 5, 2026

No description provided.

@gowerc
Copy link
Collaborator

gowerc commented Mar 5, 2026

Guesing this needs the CRAN CI update merged in for the test to pass

@luwidmer
Copy link
Collaborator Author

luwidmer commented Mar 5, 2026

Yes, both because of the version bump needed and the fix to the cran.sh script 😊

@luwidmer luwidmer assigned gravesti and unassigned gravesti Mar 5, 2026
@luwidmer luwidmer requested a review from gravesti March 5, 2026 14:34
@luwidmer
Copy link
Collaborator Author

luwidmer commented Mar 5, 2026

This addresses #547

Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luwidmer

@wolbersm
Copy link
Collaborator

wolbersm commented Mar 5, 2026

Thanks, @gravesti. I recently opened a new email account: wolbersm.statistics@gmail.com
This would be perfect for here as well.

person("Isaac", "Gravestock", email = "isaac.gravestock@roche.com", role = c("aut")),
person("Alessandro", "Noci", email = "alessandro.noci@roche.com", role = c("aut")),
person("Marcel", "Wolbers", email = "marcel.wolbers@roche.com", role = "ctb"),
person("Marcel", "Wolbers", email = "marcel.wolbers@roche.com", role = "aut"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
person("Marcel", "Wolbers", email = "marcel.wolbers@roche.com", role = "aut"),
person("Marcel", "Wolbers", email = "wolbersm.statistics@gmail.com", role = "aut"),

@luwidmer
Copy link
Collaborator Author

luwidmer commented Mar 5, 2026

@gravesti @wolbersm @gowerc @danielinteractive @nociale while we're updating the authors, should we also add ORCIDs?

@wolbersm
Copy link
Collaborator

wolbersm commented Mar 5, 2026

I think this is a good idea. Mine is 0000-0003-4915-9015

@danielinteractive
Copy link
Collaborator

@@ -6,7 +6,7 @@ Authors@R: c(
person("Craig", "Gower-Page", email = "craig.gower-page@novartis.com", role = c("aut")),
person("Isaac", "Gravestock", email = "isaac.gravestock@roche.com", role = c("aut")),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
person("Isaac", "Gravestock", email = "isaac.gravestock@roche.com", role = c("aut")),
person("Isaac", "Gravestock", email = "isaac.gravestock@roche.com", role = c("aut"), comment = c(ORCID = "0000-0003-0283-2065")),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants