Conversation
|
I ran axe across clarity. There were very few warnings most of which I know are not theme specific but here are the ones that might be worth checking:
|
joemull
left a comment
There was a problem hiding this comment.
There are some really great things here:
- one theme across journal, press, and repository
- higher accessibility conformance than any theme so far
- more organized CSS than any theme, potentially allowing us to do easier journal setups and color customization
- use of bootstrap
Haven't finished reviewing everything I want to, but as I will be out for a few days, I am returning this with some comments.
In case you are curious, here is my to do list when I get back:
- Finish reading over CSS
- Experiment with dark mode
- Test most pages on mobile on a few OLH journals
- Test most pages at press level
- Test pages in repository system
- Check if there is a theme that provides a light header, so that current Material journals can switch easily
- Create GH issue for changes made to 1.8 since d25d0bfa5
- Create GH issue for changes made to master since 891066d8
There was a problem hiding this comment.
Would you mind if we ran prettier over the HTML as a last step? This is a rare opportunity to make our HTML more readable!
Steps to do so are now quite straightforward, even though there is mustache syntax in these files. There is a plugin you can use with prettier now that was made for Jinja but works for Django templates as well.
- Install bun
- Create a
package.jsonwith this:{ "dependencies": { "prettier": "^3.6.2", "prettier-plugin-jinja-template": "^2.1.0", "prettier-plugin-toml": "^2.0.6" } } - Create a
.prettier.tomlwith this:plugins = ["prettier-plugin-jinja-template", "prettier-plugin-toml"] [[overrides]] files = ["*.jinja"] options.parser = "jinja-template"
- Run
bun install - Run
bun prettier --check templatesand fix HTML syntax errors until there aren't any more - Run
bun prettier --write templatesa few times until it makes no further changes - Consider running it on the CSS as well, though it is already quite nicely formatted.
There was a problem hiding this comment.
I'm open to running this once we're done.
See readme.