graceful ctrl c interrupt handling#688
Open
AnthonyPFAVG wants to merge 1 commit intoopenlawlibrary:masterfrom
Open
graceful ctrl c interrupt handling#688AnthonyPFAVG wants to merge 1 commit intoopenlawlibrary:masterfrom
AnthonyPFAVG wants to merge 1 commit intoopenlawlibrary:masterfrom
Conversation
Contributor
|
Thanks for the contribution! Before we can review this PR, we need to clarify a licensing point. To meet the needs of our government partners, we’re considering moving to a dual-license model (AGPL-3.0 / Apache-2.0) in the future. Because of that, we need confirmation that your contribution can be relicensed under Apache 2.0 as part of this dual-license setup if/when it happens. If that works for you, let us know and we'll proceed with review and merging. If not, that's totally fine, we'll close the PR. Thanks for understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
This PR adds graceful SIGINT (Ctrl+C) handling to update_repository. Updates can be interrupted safely without leaving repositories in a half-way/undefined state. Previously, a KeyboardInterrupt raised during update execution could cause undefined behavior. Now, the update_respository() function catches the interrupt, logs it, and raises an UpdateFailedError.
A new unit test, test_update_repository_interrupts_gracefully, simulates a (Ctrl+C) interrupt to verify this behavior.
Code review checklist (for code reviewer to complete)