Skip to content

fix: refresh repo authz data#230

Merged
minh-nghia merged 1 commit intomainfrom
fix/repo-authz-refresh
Apr 9, 2026
Merged

fix: refresh repo authz data#230
minh-nghia merged 1 commit intomainfrom
fix/repo-authz-refresh

Conversation

@minh-nghia
Copy link
Copy Markdown
Contributor

@minh-nghia minh-nghia commented Apr 9, 2026

  • Bug Fixes
    • Corrected authorization data refresh mechanism

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e455c0f2-350d-4fa7-8b46-f383d93db307

📥 Commits

Reviewing files that changed from the base of the PR and between b0bcdd8 and 871fc3f.

📒 Files selected for processing (1)
  • internal/daemon/server.go

Walkthrough

The changes fix a nil-check bug in the authorization handler validation and refactor the periodic authorization data refresh mechanism. Specifically, the nil-check for an authz handler now correctly validates authzRepoLoader.AuthzHandler instead of duplicating the authzAPILoader.AuthzHandler check. Additionally, the periodic authz data refresh initialization is updated to invoke StartAuthzDataRefresh on both authzAPILoader and authzRepoLoader individually, replacing the previous approach that initiated refresh through controller.AuthzLoader.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: refresh repo authz data' directly reflects the main change: fixing the repo authorization data refresh logic by ensuring both authzAPILoader and authzRepoLoader invoke StartAuthzDataRefresh.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@push-tags-from-workflow push-tags-from-workflow bot added the bug Something isn't working label Apr 9, 2026
@minh-nghia
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@minh-nghia minh-nghia requested a review from anettlippert April 9, 2026 13:14
@minh-nghia minh-nghia merged commit 445ca41 into main Apr 9, 2026
6 checks passed
@minh-nghia minh-nghia deleted the fix/repo-authz-refresh branch April 9, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants