Conversation
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
|
@coderabbitai review |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe pull request removes three user name fields from the data model and database schema. GORM tags for CreatorName, InitiatorName, and UserName are changed to 🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 90ef3351-2e5e-4e60-abe5-3ae7153d0436
📒 Files selected for processing (4)
internal/model/keyconfiguration.gointernal/model/workflow.gomigrations/tenant/schema/00005_delete_user_names.sqltest/db-migration/migration_test.go
18cd535 to
f181be3
Compare
d4c2686 to
b343f6c
Compare
b343f6c to
82c1dbe
Compare
| return "" | ||
| } | ||
|
|
||
| func (w *Workflow) GetInitiatorName( |
There was a problem hiding this comment.
GetInitiatorName and GetUserName have nearly the same code, can we maybe extra this into a helper?
Same helper can maybe also reused for GetCreatorName in KeyConfiguration
Requires openkcm/plugin-sdk#144
Summary by CodeRabbit
Refactor
Tests
Chores