refactor: replace KORTEX_CLI_ environment variable names to KDN_#204
refactor: replace KORTEX_CLI_ environment variable names to KDN_#204feloy merged 1 commit intoopenkaiden:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (8)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughReplaced KORTEX_CLI_* environment-variable names with KDN_* equivalents across CLI code, tests, and documentation (storage, default runtime/agent, and init auto-start). No API signatures or runtime control flow besides env-var sourcing changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/implementing-command-patterns/SKILL.md (1)
1-5:⚠️ Potential issue | 🟠 MajorAdd required Apache 2.0 + Red Hat (2026) copyright header.
This Markdown source file is missing the required copyright/license header.
As per coding guidelines, "
**/*.{go,md}: All source files must include Apache License 2.0 copyright headers with Red Hat copyright (current year 2026) - use the/copyright-headersskill for automation".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/implementing-command-patterns/SKILL.md` around lines 1 - 5, The file implementing-command-patterns (YAML front-matter in SKILL.md) is missing the required Apache-2.0 + Red Hat (2026) copyright header; add the standard copyright/license header at the top of SKILL.md (above the existing front-matter) with the Apache License 2.0 text and Red Hat (2026) copyright line so the file meets the "**/*.{go,md}" header policy.
🧹 Nitpick comments (1)
README.md (1)
957-1123: Consider adding a short migration note for users ofKORTEX_CLI_*.This is a breaking rename for shell profiles/CI scripts; a one-paragraph note can reduce upgrade friction.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 957 - 1123, Add a short migration note under the Environment Variables heading stating that environment variables formerly prefixed with KORTEX_CLI_ were renamed to KDN_ (e.g., KORTEX_CLI_DEFAULT_RUNTIME -> KDN_DEFAULT_RUNTIME, KORTEX_CLI_DEFAULT_AGENT -> KDN_DEFAULT_AGENT, KORTEX_CLI_STORAGE -> KDN_STORAGE, KORTEX_CLI_INIT_AUTO_START -> KDN_INIT_AUTO_START), show a one-line example of exporting the new name and a brief instruction to update shell profiles/CI scripts or create backwards-compatible exports if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@skills/implementing-command-patterns/SKILL.md`:
- Around line 1-5: The file implementing-command-patterns (YAML front-matter in
SKILL.md) is missing the required Apache-2.0 + Red Hat (2026) copyright header;
add the standard copyright/license header at the top of SKILL.md (above the
existing front-matter) with the Apache License 2.0 text and Red Hat (2026)
copyright line so the file meets the "**/*.{go,md}" header policy.
---
Nitpick comments:
In `@README.md`:
- Around line 957-1123: Add a short migration note under the Environment
Variables heading stating that environment variables formerly prefixed with
KORTEX_CLI_ were renamed to KDN_ (e.g., KORTEX_CLI_DEFAULT_RUNTIME ->
KDN_DEFAULT_RUNTIME, KORTEX_CLI_DEFAULT_AGENT -> KDN_DEFAULT_AGENT,
KORTEX_CLI_STORAGE -> KDN_STORAGE, KORTEX_CLI_INIT_AUTO_START ->
KDN_INIT_AUTO_START), show a one-line example of exporting the new name and a
brief instruction to update shell profiles/CI scripts or create
backwards-compatible exports if needed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2532bf18-3fb9-4e36-8124-c72527814eb0
📒 Files selected for processing (9)
AGENTS.mdREADME.mdpkg/cmd/init.gopkg/cmd/init_test.gopkg/cmd/root.gopkg/cmd/root_test.goskills/commit/SKILL.mdskills/implementing-command-patterns/SKILL.mdskills/working-with-config-system/SKILL.md
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
why KDN_ and not KAIDEN_ ?
if I use az cli, env variables are AZURE_CONFIG_DIR
if I use maven, cli is called mvn but env variables are MAVEN_OPTS
Same reason as in #205 (comment) I supposed that KAIDEN_ is related to the project, not the the cli specifically. We had chosen But we can change to another approach, I don't mind |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 participants
Fixes #202