Skip to content

feat(workspace): add MCP servers to workspace configuration#33

Open
feloy wants to merge 1 commit intoopenkaiden:mainfrom
feloy:wc-mcps
Open

feat(workspace): add MCP servers to workspace configuration#33
feloy wants to merge 1 commit intoopenkaiden:mainfrom
feloy:wc-mcps

Conversation

@feloy
Copy link
Copy Markdown
Contributor

@feloy feloy commented Apr 9, 2026

Add McpConfiguration, McpServer, and McpCommand schemas to the workspace-configuration OpenAPI spec, allowing users to configure URL-based and command-based MCP servers in their workspace.

Fixes #32

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 619306f7-4c64-41fc-8f4c-06e380e90dde

📥 Commits

Reviewing files that changed from the base of the PR and between c74cac8 and 4df87d9.

📒 Files selected for processing (1)
  • workspace-configuration/openapi.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • workspace-configuration/openapi.yaml

📝 Walkthrough

Walkthrough

Adds an mcp property to the WorkspaceConfiguration OpenAPI schema and introduces three new schemas—McpConfiguration, McpServer, and McpCommand—with examples; each MCP schema level disallows additional properties.

Changes

Cohort / File(s) Summary
OpenAPI Schema: Workspace configuration
workspace-configuration/openapi.yaml
Added WorkspaceConfiguration.mcp and three new schemas: McpConfiguration (servers, commands), McpServer (required name, url, optional headers object), and McpCommand (required name, command, optional args array, env object). Set additionalProperties: false for MCP schemas and updated the 200 response example to include mcp with a sample server and command.

Sequence Diagram(s)

(omitted — changes are schema additions without multi-component runtime control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding MCP servers to workspace configuration, which is the primary focus of the changeset.
Description check ✅ Passed The description is clearly related to the changeset, explaining the new schemas added and their purpose for configuring MCP servers in workspaces.
Linked Issues check ✅ Passed The PR implementation fully addresses issue #32 requirements: McpConfiguration with servers and commands arrays, McpServer with name/url/headers, and McpCommand with name/command/args/env properties.
Out of Scope Changes check ✅ Passed All changes in workspace-configuration/openapi.yaml are directly related to implementing the MCP server configuration feature requested in issue #32, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@workspace-configuration/openapi.yaml`:
- Around line 100-114: The McpCommand schema currently lists required: name,
command but leaves args optional; update the OpenAPI schema for McpCommand by
adding "args" to the required array so that the properties block (name, command,
args) enforces presence of args; ensure the existing args property definition
(type: array, items: string) remains unchanged and keep optional env as-is if
present elsewhere.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16420f9e-6850-4da2-8368-c5d681c13be5

📥 Commits

Reviewing files that changed from the base of the PR and between 5d1cecc and c74cac8.

📒 Files selected for processing (1)
  • workspace-configuration/openapi.yaml

@feloy feloy requested review from benoitf, jeffmaury and slemeur April 9, 2026 09:55
Add McpConfiguration, McpServer, and McpCommand schemas to the
workspace-configuration OpenAPI spec, allowing users to configure
URL-based and command-based MCP servers in their workspace.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add mcp servers to workspace configuration

2 participants