Skip to content

8381027: [lworld] Cleanup CDS code#2269

Open
matias9927 wants to merge 1 commit intoopenjdk:lworldfrom
matias9927:cds_cleanup
Open

8381027: [lworld] Cleanup CDS code#2269
matias9927 wants to merge 1 commit intoopenjdk:lworldfrom
matias9927:cds_cleanup

Conversation

@matias9927
Copy link
Copy Markdown
Contributor

@matias9927 matias9927 commented Mar 26, 2026

Files in the CDS directory have unneeded code and whitespace which make it diverge from mainline. This patch removes this code so that the only differences between lworld and mainline are from new features introduced in the branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8381027: [lworld] Cleanup CDS code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2269/head:pull/2269
$ git checkout pull/2269

Update a local copy of the PR:
$ git checkout pull/2269
$ git pull https://git.openjdk.org/valhalla.git pull/2269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2269

View PR using the GUI difftool:
$ git pr show -t 2269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2269.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 26, 2026

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 26, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@matias9927 matias9927 marked this pull request as ready for review March 27, 2026 15:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 27, 2026

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 27, 2026

@matias9927 this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout cds_cleanup
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants