[type-classes] 8380667: Prototype FP8_E5M2#2259
[type-classes] 8380667: Prototype FP8_E5M2#2259jddarcy wants to merge 6 commits intoopenjdk:type-classesfrom
Conversation
|
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
|
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
If reviewers would find it helpful, I can upload here or attach to the bug a result of diffing Float16.java compared to Float8_E5M2.java with "Float16" replaced by a "FLOAT_TYPE" token and likewise for "Float8_E5M2" in its file. This removes many inessential differences between the two files, but is still about 600 lines of changes. Many of the remaining changes stem from different parameter names, "f16" vs "f8", and the use of "short" vs "byte". |
|
Pushed a small refactoring: the floating-point valued constants are initialized using the valueOf factories rather than setting the bits directly. Checking the setting of the bits is moved to the regression test. |
First cut at a prototype of an FP8 type, this one with 5 exponent bits and 2 significand (mantissa) bits.
The base conversion functionality is not fully ported over.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2259/head:pull/2259$ git checkout pull/2259Update a local copy of the PR:
$ git checkout pull/2259$ git pull https://git.openjdk.org/valhalla.git pull/2259/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2259View PR using the GUI difftool:
$ git pr show -t 2259Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2259.diff
Using Webrev
Link to Webrev Comment