Skip to content

Update README with end recording command#112

Open
maykelrodrigs-source wants to merge 1 commit intoopenjdk:premainfrom
maykelrodrigs-source:patch-1
Open

Update README with end recording command#112
maykelrodrigs-source wants to merge 1 commit intoopenjdk:premainfrom
maykelrodrigs-source:patch-1

Conversation

@maykelrodrigs-source
Copy link
Copy Markdown

@maykelrodrigs-source maykelrodrigs-source commented Mar 19, 2026

Fix documentation: replace AOT.end_training with AOT.end_recording

The documentation refers to jcmd AOT.end_training as the command to end a training run, but this command does not exist. The correct command is jcmd AOT.end_recording.

Running the documented command produces:

java.lang.IllegalArgumentException: Unknown diagnostic command
Verified on builds b487 and b489 (27-testing, 2026-03-18, linux/x86_64).


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/112/head:pull/112
$ git checkout pull/112

Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.org/leyden.git pull/112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 112

View PR using the GUI difftool:
$ git pr show -t 112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/112.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 19, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 19, 2026

Hi @maykelrodrigs-source, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user maykelrodrigs-source" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 19, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@maykelrodrigs-source
Copy link
Copy Markdown
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Mar 19, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 19, 2026

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant