Update README with end recording command#112
Update README with end recording command#112maykelrodrigs-source wants to merge 1 commit intoopenjdk:premainfrom
Conversation
|
Hi @maykelrodrigs-source, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user maykelrodrigs-source" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Fix documentation: replace AOT.end_training with AOT.end_recording
The documentation refers to jcmd AOT.end_training as the command to end a training run, but this command does not exist. The correct command is jcmd AOT.end_recording.
Running the documented command produces:
java.lang.IllegalArgumentException: Unknown diagnostic command
Verified on builds b487 and b489 (27-testing, 2026-03-18, linux/x86_64).
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/112/head:pull/112$ git checkout pull/112Update a local copy of the PR:
$ git checkout pull/112$ git pull https://git.openjdk.org/leyden.git pull/112/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 112View PR using the GUI difftool:
$ git pr show -t 112Using diff file
Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/112.diff