Skip to content

8375177: Gtest os_linux.decoder_get_source_info_valid_vm fails with -ffunction-sections #30516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MBaesken wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

8375177: Gtest os_linux.decoder_get_source_info_valid_vm fails with -ffunction-sections #30516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions make/autoconf/flags-cflags.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,9 @@ AC_DEFUN([FLAGS_SETUP_CFLAGS_HELPER],
# reduce lib size on linux in link step, this needs also special compile flags
# do this on s390x also for libjvm (where serviceability agent is not supported)
if test "x$ENABLE_LINKTIME_GC" = xtrue; then
TOOLCHAIN_CFLAGS_JDK="$TOOLCHAIN_CFLAGS_JDK -ffunction-sections -fdata-sections"
TOOLCHAIN_CFLAGS_JDK="$TOOLCHAIN_CFLAGS_JDK -ffunction-sections -DUSE_FUNCTION_SECTIONS -fdata-sections"
if test "x$OPENJDK_TARGET_CPU" = xs390x && test "x$DEBUG_LEVEL" == xrelease; then
TOOLCHAIN_CFLAGS_JVM="$TOOLCHAIN_CFLAGS_JVM -ffunction-sections -fdata-sections"
TOOLCHAIN_CFLAGS_JVM="$TOOLCHAIN_CFLAGS_JVM -ffunction-sections -DUSE_FUNCTION_SECTIONS -fdata-sections"
fi
fi
# technically NOT for CXX (but since this gives *worse* performance, use
Expand Down Expand Up @@ -579,8 +579,8 @@ AC_DEFUN([FLAGS_SETUP_CFLAGS_HELPER],
fi

if test "x$ENABLE_LINKTIME_GC" = xtrue; then
TOOLCHAIN_CFLAGS_JDK="$TOOLCHAIN_CFLAGS_JDK -ffunction-sections -fdata-sections"
TOOLCHAIN_CFLAGS_JVM="$TOOLCHAIN_CFLAGS_JVM -ffunction-sections -fdata-sections"
TOOLCHAIN_CFLAGS_JDK="$TOOLCHAIN_CFLAGS_JDK -ffunction-sections -DUSE_FUNCTION_SECTIONS -fdata-sections"
TOOLCHAIN_CFLAGS_JVM="$TOOLCHAIN_CFLAGS_JVM -ffunction-sections -DUSE_FUNCTION_SECTIONS -fdata-sections"
fi

if test "x$OPENJDK_TARGET_OS" = xaix; then
Expand Down
2 changes: 2 additions & 0 deletions test/hotspot/gtest/runtime/test_os_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,9 @@ TEST_VM(os_linux, decoder_get_source_info_valid) {
int line = -1;
address valid_function_pointer = (address)ReportJNIFatalError;
ASSERT_TRUE(Decoder::get_source_info(valid_function_pointer, buf, sizeof(buf), &line));
#if !defined(USE_FUNCTION_SECTIONS)
EXPECT_STREQ(buf, "jniCheck.hpp");
#endif
ASSERT_TRUE(line > 0);
}

Expand Down