8378740: Suppressed warnings reported when implicit compilation is combined with annotation processing by lahodaj · Pull Request #30110 · openjdk/jdk

lahodaj · 2026-03-06T07:41:38Z

As part of @david-beaumont's work on openjdk/valhalla#2180, it turned out warnings are sometimes reported to a wrong file when annotation processors are present, and, as a consequence, these warnings are not properly suppressed by @SuppressWarnings.

The reason is simple: the log.useSource is misplaced, and the source in the Log may not be correctly reset. The source is correctly reset if tree == null, which is the normal case without annotation processing. But with annotation processing combined with implicit compilation, tree != null, and the source is never reset to the original value. And subsequent diagnostic then may be assigned to a wrong file.

This PR is moving setting the source to the correct place.

Note that for testCorrectSource, there are multiple warnings printed. This is an pre-existing problem that is sadly harder to fix albeit hopefully with a smaller severity. I think it would be better tackled separately. I've filled https://bugs.openjdk.org/browse/JDK-8378950 for it.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8378740: Suppressed warnings reported when implicit compilation is combined with annotation processing (Bug - P3)

Reviewers

David Beaumont (@david-beaumont - Committer) Review applies to 8155ddc3
Chen Liang (@liach - Reviewer)
Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30110/head:pull/30110
$ git checkout pull/30110

Update a local copy of the PR:
$ git checkout pull/30110
$ git pull https://git.openjdk.org/jdk.git pull/30110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30110

View PR using the GUI difftool:
$ git pr show -t 30110

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30110.diff

Using Webrev

Link to Webrev Comment

…mbined with annotation processing

bridgekeeper · 2026-03-06T07:43:46Z

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-06T07:45:14Z

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378740: Suppressed warnings reported when implicit compilation is combined with annotation processing

Reviewed-by: liach, vromero, dbeaumont

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 199 new commits pushed to the master branch:

d3158e7: 8379628: Refactor langtools/shellsupport/doc tests to use JUnit
680503c: 8378470: Add future Intel family number
5aa115b: 8379622: Problemlist java/nio/channels/SocketChannel/OpenLeak.java and CloseDuringConnect.java on macos 26
... and 196 more: https://git.openjdk.org/jdk/compare/fd48f68a2cc69a0cccbc2503f29aad2de19ec098...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-03-06T07:46:18Z

@lahodaj The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-03-06T07:50:03Z

Webrevs

david-beaumont

Looks good. A few optional suggestions.

david-beaumont · 2026-03-06T11:25:05Z

test/langtools/tools/javac/implicitCompile/APImplicitClassesWarnings.java

+/*
+ * @test
+ * @bug 8378740
+ * @summary Verify warnings are properly suppress in the combination of


nit: "suppress in" --> "suppressed for" ?

david-beaumont · 2026-03-06T11:29:04Z

test/langtools/tools/javac/implicitCompile/APImplicitClassesWarnings.java

+
+public class APImplicitClassesWarnings {
+
+    ToolBox tb = new ToolBox();


nit: final (and maybe private)

I know it's not super important but as a reader of code, it's nice to not have lingering questions about "why or when could this change". A final field can just be read once and completely understood.

david-beaumont · 2026-03-06T11:32:42Z

test/langtools/tools/javac/implicitCompile/APImplicitClassesWarnings.java

+    public void testCorrectSuppress() throws Exception {
+        Path src = base.resolve("src");
+        Path classes = base.resolve("classes");
+        tb.writeJavaFiles(src,


Maybe a comment saying that the only difference here is the one suppression line.
It saves me having to do a line-by-line scan to know what changed.

liach · 2026-03-10T15:56:43Z

src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

This file can get a year bump.

Update copyright year.

openjdk · 2026-03-10T16:29:59Z

⚠️ @lahodaj This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

vicente-romero-oracle

lgtm

lahodaj · 2026-03-12T06:17:37Z

/integrate

openjdk · 2026-03-12T06:19:05Z

Going to push as commit 39a2566.
Since your change was applied there have been 226 commits pushed to the master branch:

814b7f5: 8378920: Remove AppContext from SequencedEvent
30e569d: 8379021: Shenandoah: Speedup ShenandoahSimpleBitMapTest
c315d1c: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified
... and 223 more: https://git.openjdk.org/jdk/compare/fd48f68a2cc69a0cccbc2503f29aad2de19ec098...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-12T06:19:16Z

@lahodaj Pushed as commit 39a2566.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

lahodaj added 2 commits February 26, 2026 08:58

8378740: Suppressed warnings reported when implicit compilation is co…

69a6112

…mbined with annotation processing

Improving test.

8155ddc

openjdk bot added the compiler compiler-dev@openjdk.org label Mar 6, 2026

openjdk bot added the rfr Pull request is ready for review label Mar 6, 2026

david-beaumont approved these changes Mar 6, 2026

View reviewed changes

Reflecting review feedback.

5f40222

liach approved these changes Mar 10, 2026

View reviewed changes

liach reviewed Mar 10, 2026

View reviewed changes

src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

Copy link
Copy Markdown

Member

liach Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can get a year bump.

openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2026

lahodaj added 2 commits March 10, 2026 17:26

Update copyright year.

562e88d

Merge pull request #11 from lahodaj/lahodaj-patch-2

2da9337

Update copyright year.

liach approved these changes Mar 10, 2026

View reviewed changes

vicente-romero-oracle approved these changes Mar 10, 2026

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 12, 2026

openjdk bot closed this Mar 12, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2026

david-beaumont mentioned this pull request Mar 12, 2026

8379906: [lworld] CLONE - Suppressed warnings reported when implicit compilation is combined with annotation processing openjdk/valhalla#2221

Closed

3 tasks


		public class APImplicitClassesWarnings {

		ToolBox tb = new ToolBox();

Conversation

lahodaj commented Mar 6, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

david-beaumont left a comment

Choose a reason for hiding this comment

Uh oh!

david-beaumont Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

david-beaumont Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

david-beaumont Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

liach Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Mar 10, 2026

Uh oh!

vicente-romero-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

lahodaj commented Mar 12, 2026

Uh oh!

openjdk bot commented Mar 12, 2026

Uh oh!

openjdk bot commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

lahodaj commented Mar 6, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 6, 2026 •

edited

Loading

openjdk bot commented Mar 6, 2026 •

edited

Loading

mlbridge bot commented Mar 6, 2026 •

edited

Loading