Skip to content

Feature/podcast player#239

Closed
SpkArtZen wants to merge 14 commits intoopenhome-dev:devfrom
SpkArtZen:feature/podcast_player
Closed

Feature/podcast player#239
SpkArtZen wants to merge 14 commits intoopenhome-dev:devfrom
SpkArtZen:feature/podcast_player

Conversation

@SpkArtZen
Copy link
Copy Markdown

What does this Ability do?

Suggested Trigger Words

Type

  • New community Ability
  • Improvement to existing Ability
  • Bug fix
  • Documentation update

External APIs

  • No external APIs
  • Uses external API(s):

Testing

  • Tested in OpenHome Live Editor
  • All exit paths tested (said "stop", "exit", etc.)
  • Error scenarios tested (API down, bad input, etc.)

Checklist

  • Files are in community/my-ability-name/
  • main.py follows SDK pattern (extends MatchingCapability, has register_capability + call)
  • README.md included with description, suggested triggers, and setup
  • resume_normal_flow() called on every exit path
  • No print() — using editor_logging_handler
  • No hardcoded API keys — using placeholders
  • No blocked imports (redis, user_config)
  • No asyncio.sleep() or asyncio.create_task() — using session_tasks
  • Error handling on all external calls
  • Tested in OpenHome Live Editor

Anything else?

@SpkArtZen SpkArtZen requested review from a team as code owners April 1, 2026 10:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🔀 Branch Merge Check

PR direction: feature/podcast_playerdev

Passedfeature/podcast_playerdev is a valid merge direction

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

✅ Community PR Path Check — Passed

All changed files are inside the community/ folder. Looks good!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

✅ Ability Validation Passed

📋 Validating: community/podcast-player
  ✅ All checks passed!

@github-actions github-actions bot added the community-ability Community-contributed ability label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🔍 Lint Results

__init__.py — Empty as expected

Files linted: community/podcast-player/main.py

✅ Flake8 — Passed

✅ All checks passed!

uzair401 added 2 commits April 1, 2026 15:34
Signed-off-by: Uzair Ullah <uzairullahmail@gmail.com>
@uzair401
Copy link
Copy Markdown
Contributor

uzair401 commented Apr 1, 2026

Hi @SpkArtZen, please update your code to follow the new SDK changes for API key management as outlined in the docs: https://docs.openhome.com/OpenHome_SDK_Reference#15-custom-api-keys

Also since this ability uses a paid service API key, please also provide a Loom demo showing the full working flow with the actual service. Once that’s submitted, we can proceed with the review and approval.

@uzair401 uzair401 closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-ability Community-contributed ability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants