Open
Conversation
…ations - Added .oxfmtrc.jsonc for oxfmt configuration, specifying formatting rules and patterns. - Replaced prettier with oxfmt in package.json files across multiple packages for consistent formatting. - Updated pnpm-lock.yaml and pnpm-workspace.yaml to reflect the new oxfmt dependency. - Adjusted scripts in various package.json files to utilize oxfmt for formatting tasks. This change enhances code consistency and streamlines the formatting process across the monorepo.
…ttings - Updated VSCode extension recommendations to include oxc.oxc-vscode. - Replaced Prettier with oxfmt as the default formatter in settings.json. - Added oxfmt configuration path for enhanced formatting control. This change aligns with the recent integration of oxfmt for consistent code formatting across the project.
…to oxfmt - Deleted Prettier configuration files including index.js, package.json, and tsconfig.json from the tooling/prettier directory. - This change supports the ongoing migration to oxfmt for code formatting across the project.
- Replaced mentions of Prettier with Oxfmt in the README. - Added .oxfmtrc.jsonc file reference for Oxfmt configuration. - Adjusted formatting table for clarity and consistency. This change ensures the documentation aligns with the recent migration to Oxfmt for code formatting.
- Reformatted various files to ensure consistent code style, including adding and removing whitespace. - Updated import statements and comments for clarity and consistency. - This change enhances code readability and maintains uniformity across the project.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What problem are you trying to solve? What issue does this close?
Standardize the monorepo on Oxfmt (Oxc formatter) instead of Prettier and the shared
@acme/prettier-config, so formatting is faster, aligned with the Oxc toolchain, and configured in one place (.oxfmtrc.jsonc). This also updates editor setup so contributors format with the Oxc VS Code extension instead of Prettier.Solution
How did you solve the problem?
.oxfmtrc.jsoncat the repo root (print width, quotes, semicolons, Tailwind class sorting forcn/cva,package.jsonscript sorting, import sorting with React/Next/@acmegroups). Turbo generator Handlebars templates are excluded viaignorePatterns.@acme/prettier-config/ directprettierfrom packages that used them (e.g.apps/web), removed thetooling/prettierpackage from the documented tree, and registeredoxfmton the pnpm catalog withoxfmtas a dev dependency whereformatruns.prettier --check-styleformatscripts withoxfmt, still respecting.gitignorevia--ignore-pathwhere used; rootpnpm format/pnpm format:fixcontinue to run formatting through Turbo.oxc.oxc-vscode, seteditor.defaultFormatterto it,oxc.fmt.configPathto.oxfmtrc.jsonc, removed Prettier-specific settings..oxfmtrc.jsonc..github/workflows/codeql.yml.Features:
Improvements:
Bug Fixes:
on.push/on.pull_requestbranch list indentation normalized.Before & After Screenshots
⚡️ It's ~2x faster
Up to ~2.8x faster on Isomer
Tests
What tests should be run to confirm functionality?
pnpm install(lockfile consistent)pnpm format(and/orpnpm format:fixthen a cleangit diffreview)pnpm lintpnpm typecheckpnpm testorpnpm test:cias you normally run in CIOptional: open the repo in VS Code and confirm Format Document uses Oxc and picks up
.oxfmtrc.jsonc.Deploy Notes
Notes regarding deployment of the contained body of work.
New environment variables:
New scripts:
formatnow invokesoxfmtinstead ofprettier.New dependencies:
New dev dependencies:
oxfmt(via pnpmcatalog:, e.g.^0.41.0) — repo-wide formatter CLI and editor integration target.Removed / stopped using:
@acme/prettier-config, directprettierin packages that previously depended on them for formatting (Prettier may still appear transitively via tools like Storybook in the lockfile; that is unchanged by this migration).