Catch2 tests coverage for MapLayerBaseModel and MapLayerModel#7095
Catch2 tests coverage for MapLayerBaseModel and MapLayerModel#7095kaustuvpokharel wants to merge 3 commits intomasterfrom
Conversation
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🪟 Windows buildsDownload a Windows build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
|
@kaustuvpokharel , you can test the writable filter by tweaking the |
@kaustuvpokharel , you can get that by adding a |
nirvn
left a comment
There was a problem hiding this comment.
What's in there looks good, I've added two comments to guide you to add the missing bits.
ed210df to
a9532af
Compare
MapLayerBaseModel tests cover initial state, layer population on setProject, dynamic addition/removal via project signals, all five data roles, invalid index handling, list model parent contract, disabled state ignoring signal-driven changes, the disabled/project-switch/re-enable lifecycle, signal deduplication guards on setEnabled and setProject, and project switching
WHile,
MapLayerModel tests cover default state, alphabetical sorting, all geometry-type filters (PointLayer, LineLayer, PolygonLayer, NoGeometry, HasGeometry combined with PointLayer to reach the detectGeometry branch), filtersChanged signal deduplication, findLayer with valid/null/orphan inputs, get() with valid and invalid rows, disabled state, requiresTrackingAvailability with no TrackingModel, requiresTrackingAvailability with a TrackingModel present but no active tracking, and requiresTrackingAvailabilityChanged signal deduplication
##FIndings