[DONE] FIX : Use docker compose with apple silicon chip#1089
Open
[DONE] FIX : Use docker compose with apple silicon chip#1089
Conversation
kernicPanel
reviewed
Apr 25, 2025
Member
kernicPanel
left a comment
kernicPanel
left a comment
There was a problem hiding this comment.
IMO, we should not use pseudo tags in PR titles (like [DONE]) instead we should use the draft state.
| $ make bootstrap | ||
| ``` | ||
|
|
||
| > Please note that with apple silicon (Mx chips), you may encounter difficulties launching docker compose, notably because some images are not compatible. In this case, you can specify the platform in the docker compose file, as in the example below: |
Member
There was a problem hiding this comment.
Can you keep the line length around 80 chars, please ?
It's easier to read, and keeps consistency around the project.
| > - app | ||
| > | ||
| > dockerize: | ||
| > + platform: "linux/amd64" |
Member
There was a problem hiding this comment.
As we discussed, we should try to use export DOCKER_DEFAULT_PLATFORM=linux/amd64 instead of keeping uncommited edits in docker-compose.yml.
Member
|
I share the same idea than @kernicPanel, I would just make the title the following way : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add comment in readme to use docker compose with apple silicon