Skip to content

feat(go-sdk): streaming list objects endpoint#651

Merged
rhamzeh merged 3 commits intomainfrom
feat/go-sdk/streaming-list-endpnt
Nov 19, 2025
Merged

feat(go-sdk): streaming list objects endpoint#651
rhamzeh merged 3 commits intomainfrom
feat/go-sdk/streaming-list-endpnt

Conversation

@SoulPancake
Copy link
Copy Markdown
Member

@SoulPancake SoulPancake commented Oct 25, 2025

Description

This was used to generate the API layer changes for the streaming list objects endpoint

What problem is being solved?

For the issue #76 in the go-sdk
generates openfga/go-sdk#252

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated the Go client build process configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 25, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The Makefile's Go client build process was modified to use make build-client-streamed instead of make build-client, while keeping all subsequent build steps (gofmt, go mod tidy, per-example tidy) unchanged.

Changes

Cohort / File(s) Summary
Build configuration
Makefile
Modified build-client-go target to invoke make build-client-streamed instead of make build-client with identical parameters

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "feat(go-sdk): streaming list objects endpoint" directly corresponds to the primary objective of this pull request. The raw summary shows that the Makefile change switches the Go client build from make build-client to make build-client-streamed, which implements the infrastructure for the streaming list objects endpoint feature. The PR objectives confirm this is intended to address streaming endpoint support for the Go SDK. The title is concise, specific, and clearly conveys the main change without ambiguity or unnecessary noise.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/go-sdk/streaming-list-endpnt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SoulPancake SoulPancake changed the title WIP feat(go-sdk): streaming list objects endpoint feat(go-sdk): streaming list objects endpoint Oct 28, 2025
@SoulPancake SoulPancake marked this pull request as ready for review October 28, 2025 04:32
@SoulPancake SoulPancake requested a review from a team as a code owner October 28, 2025 04:32
Copilot AI review requested due to automatic review settings October 28, 2025 04:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the streaming list objects endpoint for the Go SDK by modifying the build process to use a streaming-specific client generator target instead of the standard one.

Key Changes:

  • Modified the Go SDK build target to use build-client-streamed instead of build-client

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19d1271 and 210f7c1.

📒 Files selected for processing (1)
  • Makefile (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Makefile

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Makefile: Update OPEN_API_REF in the Makefile when targeting new OpenFGA API versions
Update Docker image tags in the Makefile when upgrading build tools
Use official, tagged Docker images for containerized builds

Files:

  • Makefile

@rhamzeh rhamzeh added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 5860546 Nov 19, 2025
15 checks passed
@rhamzeh rhamzeh deleted the feat/go-sdk/streaming-list-endpnt branch November 19, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants