Conversation
4 tasks
evansims
force-pushed
the
fix/python/rest-client-should-not-close-after-stream
branch
from
9d75be2 to
b8365f2
Compare
evansims
force-pushed
the
fix/python/rest-client-should-not-close-after-stream
branch
from
b8365f2 to
cc3bb6e
Compare
jimmyjames
approved these changes
Feb 14, 2025
evansims
deleted the
fix/python/rest-client-should-not-close-after-stream
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a minor bug fix to the new
streammethod added to the Python SDK's REST client in 0.9.1: the pool shouldn't close after the request concludes, as the same pool can continue to be used for future requests.References
Generates openfga/python-sdk#172
Review Checklist
main