Merged
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (70.38%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 69.58% 70.38% +0.79%
==========================================
Files 135 134 -1
Lines 10864 10794 -70
==========================================
+ Hits 7560 7597 +37
+ Misses 3304 3197 -107 ☔ View full report in Codecov by Sentry. |
4 tasks
7cc19d1 to
9c85094
Compare
f25d5da to
a2849a4
Compare
a2849a4 to
894509a
Compare
rhamzeh
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a first pass at type hinting improvements I'm making to the SDK. This first pass addresses errors in the existing type hints and ensures our client models are fully typed and hinted appropriately.
This pull request adds the
mypystatic type linter to our build process and an initial configuration for it to thepyproject.tomlfile. Note that there are a few commented-out flags; I intend to enable these with future passes.References
This PR is a step towards addressing #109, but further work is required before we can call that closed.
Generated from openfga/sdk-generator#480
Review Checklist
main