Conversation
4 tasks
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (69.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
+ Coverage 69.56% 69.58% +0.01%
==========================================
Files 135 135
Lines 10857 10864 +7
==========================================
+ Hits 7553 7560 +7
Misses 3304 3304 ☔ View full report in Codecov by Sentry. |
rhamzeh
reviewed
Jan 28, 2025
24d73b5 to
fe5ae46
Compare
fe5ae46 to
2ec56b1
Compare
rhamzeh
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request does not include any functionality changes. It introduces a faster and more streamlined linter and code formatted tool and applies some suggested code formatting rules.
Changes include:
Updates the linter and code formatting tools used.
rufflinter and code formatted tool.pyupgrade,isort,autoflakeandblacktools.setup.cfgfile with a modernpyproject.tomlequivalent.Applies improvements suggested by the tool:
__all__definitions to the__init__.pyfiles as a best practice for exposing the SDK's public API to developer IDEs.Fixes a few minor issues in the examples and unit tests I identified while working on updating things:
setup.pyfiles using incorrect header comment blocks.api_test, which may have causedtest_500_error_retrynot to be run as intended.Ensures the
partial_headerblock is imported in all Python source files.References
Please review
DXAZT-368for additional context.Generated from: openfga/sdk-generator#478
Review Checklist
main