chore: make streamed list objects client methods public#271
chore: make streamed list objects client methods public#271SoulPancake merged 2 commits intomainfrom
Conversation
This reverts commit 944ecd8.
WalkthroughThis change exposes the StreamedListObjects streaming API by converting previously unexported client methods to public exports, updates documentation and examples to reflect the new public interface, and adds changelog entries to document the feature. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (33.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 33.59% 33.59%
=======================================
Files 115 115
Lines 9810 9810
=======================================
Hits 3296 3296
Misses 6252 6252
Partials 262 262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR makes the StreamedListObjects API methods public by reverting a previous change that made them private. The change enables users to access the streaming variant of the ListObjects endpoint, which is particularly useful for handling large result sets from computed relations without pagination limits.
Key changes:
- Made
StreamedListObjectsandStreamedListObjectsExecutemethods public in the client interface and implementation - Updated all test references from lowercase
streamedListObjectsto uppercaseStreamedListObjects - Re-enabled the example code demonstrating the StreamedListObjects functionality
- Added comprehensive documentation to the README with usage examples
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| client/client.go | Made StreamedListObjects and StreamedListObjectsExecute methods public by capitalizing them; added them to the SdkClient interface |
| client/streaming_test.go | Updated all test method calls from streamedListObjects to StreamedListObjects to use the newly public method |
| example/streamed_list_objects/main.go | Uncommented the complete working example code that demonstrates StreamedListObjects usage |
| README.md | Added "Streamed List Objects" section with comprehensive documentation, code example, and explanation of key differences from standard ListObjects |
| CHANGELOG.md | Added changelog entry for StreamedListObjects endpoint support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Siddhant-K-code
left a comment
There was a problem hiding this comment.
Changes overall look good. Do we have an open issue for this?
|
@Siddhant-K-code Just as a part of the overall issue of making streamed list objects available for public use Parent issue : openfga/sdk-generator#76 |
Making streamed list objects client methods, examples and documentation public
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.