Skip to content

Add feedback xblock#13

Open
salman2013 wants to merge 7 commits intomainfrom
salman/feedbackblock
Open

Add feedback xblock#13
salman2013 wants to merge 7 commits intomainfrom
salman/feedbackblock

Conversation

@salman2013
Copy link
Copy Markdown

@salman2013 salman2013 commented Apr 3, 2026

Description:

In this PR i resolved this #6

Testing output:

  • Pip Install xblocks-contrib under edx-platform/src/xblocks-contrib
  • Add "feedback" in course advance setting
  • Add the 'Provide Feedback' in Advance component.

Testing Results:

Studio


Screenshot 2026-04-07 at 11 16 14 AM

LMS


Screenshot 2026-04-07 at 11 16 37 AM

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 3, 2026

Thanks for the pull request, @salman2013!

This repository is currently unmaintained.

🔘 Find a technical reviewer To get help with finding a technical reviewer, reach out to the community contributions project manager for this PR:
  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your project manager.
  2. Find their GitHub handle here.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 3, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (3c4c8d1) to head (563e0ce).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           1        1           
  Lines           6        6           
  Branches        1        1           
=======================================
  Hits            5        5           
  Partials        1        1           
Flag Coverage Δ
unittests 83.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salman2013 salman2013 marked this pull request as ready for review April 6, 2026 07:03
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Apr 6, 2026
@mphilbrick211 mphilbrick211 requested a review from feanil April 6, 2026 19:01
@salman2013 salman2013 requested review from farhan and irtazaakram April 7, 2026 06:22
@farhan
Copy link
Copy Markdown

farhan commented Apr 7, 2026

  1. These entry points should be defined in the pyproject.toml
    https://github.com/openedx/FeedbackXBlock/blob/master/setup.py#L43-L53
  2. We didn't move this icon: https://github.com/openedx/FeedbackXBlock/blob/master/numerical_example.png

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ignore these mac OS files.
I have added them to .gitignore in my PR

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file still exist

@salman2013 salman2013 requested a review from farhan April 7, 2026 10:49
@farhan
Copy link
Copy Markdown

farhan commented Apr 9, 2026

Things look good,
@salman2013 Please confirm; Have we done the testing of instructor dashboard, using the following tutor inline plugins? Sharing of the screenshot will be great.

https://github.com/openedx/FeedbackXBlock?tab=readme-ov-file#tutor-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants