This repository was archived by the owner on Nov 10, 2021. It is now read-only.
Security CR50: replace deviceid with deviceuuid#3
Open
danmihai1 wants to merge 2 commits intoopenconnectivityfoundation:ocf/1.0/specfrom
Open
Security CR50: replace deviceid with deviceuuid#3danmihai1 wants to merge 2 commits intoopenconnectivityfoundation:ocf/1.0/specfrom
danmihai1 wants to merge 2 commits intoopenconnectivityfoundation:ocf/1.0/specfrom
Conversation
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
habibvirji
reviewed
Mar 28, 2017
|
|
||
| title Client-directed Certificate Transfer | ||
|
|
||
| participant "Credential Management Service" as CMS |
There was a problem hiding this comment.
Please divide this in multiple line such as "Credential\nManagement\nService"
habibvirji
reviewed
Mar 28, 2017
| CMS->DEV: RETRIEVE /oic/sec/csr | ||
| DEV->CMS: RSP [{"csr":"<contents of CSR>", "encoding":"<supported-encoding-type>"}] | ||
|
|
||
| CMS->DEV: UPDATE /oic/sec/cred [{"credtype":8, "subject":"deviceuuid", "credusage":"primary_cert", "publicdata":"<DER-encoded device and CA certificate chain in base64>"}] |
There was a problem hiding this comment.
Break this line also into two lines
CMS->DEV: UPDATE /oic/sec/cred [{"credtype":8, "subject":"deviceuuid", "credusage":"primary_cert", \n"publicdata":""}]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Mihai Daniel.Mihai@microsoft.com