Skip to content

Remove GITHB_TOKEN from linter args#25

Merged
bstoll merged 2 commits intoopenconfig:mainfrom
bstoll:status-updates
Oct 20, 2025
Merged

Remove GITHB_TOKEN from linter args#25
bstoll merged 2 commits intoopenconfig:mainfrom
bstoll:status-updates

Conversation

@bstoll
Copy link
Copy Markdown
Contributor

@bstoll bstoll commented Oct 17, 2025

Remove the GITHUB_TOKEN from the linter action. The token is used to write updates to the GitHub status API, but this only works for branches in the same repository. Pull requests from a forked branch will never have permission to write to the status API.

Log messages look something like this, which is difficult to follow the real errors when the log is interleaved with expected API failures:

Notice: 15 23:08:58 [NOTICE]   Successfully linted GIT_MERGE_CONFLICT_MARKERS
2025-10-15 23:08:58 [INFO]   Failed to call GitHub Status API: curl: (22) The requested URL returned error: 403
Notice: 15 23:08:58 [NOTICE]   Successfully linted GO
2025-10-15 23:08:58 [INFO]   Failed to call GitHub Status API: curl: (22) The requested URL returned error: 403
Notice: 15 23:08:58 [NOTICE]   Successfully linted GO_MODULES
2025-10-15 23:08:58 [INFO]   Failed to call GitHub Status API: curl: (22) The requested URL returned error: 403
Error: -15 23:08:58 [ERROR]   Errors found in JSCPD

@bstoll bstoll marked this pull request as ready for review October 20, 2025 19:19
@bstoll bstoll merged commit 24a4643 into openconfig:main Oct 20, 2025
2 checks passed
@bstoll bstoll deleted the status-updates branch October 20, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants