Skip to content

chore(all): update dependency protobuf to v34.1#292

Open
renovate-bot wants to merge 1 commit intoopenconfig:mainfrom
renovate-bot:renovate/protobuf-monorepo
Open

chore(all): update dependency protobuf to v34.1#292
renovate-bot wants to merge 1 commit intoopenconfig:mainfrom
renovate-bot:renovate/protobuf-monorepo

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
protobuf bazel_dep minor 34.0.bcr.134.1

Release Notes

protocolbuffers/protobuf (protobuf)

v34.1: Protocol Buffers v34.1

Announcements

  • Protobuf News may include additional announcements or pre-announcements for upcoming changes.

Bazel

  • Moved protocopt flag out of the cc dir, since it is not a c++-specific flag. (3db9fd1)
  • Add support for bazel 9.x (#​26201) (763c5da)

C++

  • Updated CMake dependencies. (5583485)
  • Add cc_proto_library for MessageSet in //src/google/protobuf/bridge (523a6a4)
  • Add support for bazel 9.x (#​26201) (763c5da)

Java

  • Avoid toBigIntegerExact in JsonFormat to avoid degenerate parse behavior in the face of large exponents. (ab3d7f0)

Python

Other

  • Fixed release_prep.sh script mkdir command to follow INTEGRITY_FILE location. (e700d7d)
  • Second try at fixing the release_prep.sh file path! (#​26097) (f5ccaf3)

Configuration

📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine update of the protobuf dependency to its latest minor version, v34.1. This upgrade ensures the project benefits from the latest features, bug fixes, and Bazel compatibility improvements provided by the Protobuf library. Concurrently, the Bazel module lock file has been comprehensively synchronized, incorporating the updated Protobuf version and bringing numerous other module dependencies up to date, thereby maintaining consistency and stability across the build system.

Highlights

  • Protobuf Dependency Update: The protobuf dependency has been updated to version 34.1 from 34.0.bcr.1 in MODULE.bazel. This is a minor version upgrade.
  • Bazel Module Lock File Synchronization: The MODULE.bazel.lock file has been extensively updated to reflect the new protobuf version and synchronize various other Bazel module dependencies. This includes updates or additions for modules such as abseil-py, apple_support, aspect_bazel_lib, bazel_features, bazel_lib, bazel_worker_api, bazel_worker_java, gawk, jq.bzl, jsoncpp, package_metadata, rules_android, rules_go, rules_java, rules_jvm_external, rules_kotlin, rules_python, rules_robolectric, rules_shell, tar.bzl, yq.bzl, and go toolchain definitions.
  • Protobuf v34.1 Release Notes: Key changes in Protobuf v34.1 include moving the protocopt flag out of the cc directory, adding support for Bazel 9.x across C++ and Python, updating CMake dependencies for C++, adding cc_proto_library for MessageSet in //src/google/protobuf/bridge, and a fix in Java's JsonFormat to avoid toBigIntegerExact issues with large exponents.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates the protobuf dependency to version 34.1 and includes corresponding updates in MODULE.bazel and MODULE.bazel.lock. The changes involve updating the version number in MODULE.bazel and adding/updating several module hashes in MODULE.bazel.lock. The review focuses on ensuring the correctness and security of these dependency updates.

Comment on lines +254 to +255
"https://bcr.bazel.build/modules/protobuf/34.1/MODULE.bazel": "41b4bf342b86021f7be1ee912cd140ef300fe527c4949b435f037cda74677f90",
"https://bcr.bazel.build/modules/protobuf/34.1/source.json": "9cf0686caa5d920a7e7c0401f76f075df76ea7ad7c064df442b6c029106a6d06",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

high: It's crucial to verify the integrity and authenticity of the new protobuf version. Ensure that the SHA256 hash 9cf0686caa5d920a7e7c0401f76f075df76ea7ad7c064df442b6c029106a6d06 is correct and matches the expected value from a trusted source (e.g., the official protobuf release page or a known-good registry). A mismatch could indicate a compromised dependency.

bazel_dep(name = "gazelle", version = "0.47.0", repo_name = "bazel_gazelle")
bazel_dep(name = "grpc", version = "1.76.0.bcr.1", repo_name = "com_github_grpc_grpc")
bazel_dep(name = "protobuf", version = "34.0.bcr.1", repo_name = "com_google_protobuf")
bazel_dep(name = "protobuf", version = "34.1", repo_name = "com_google_protobuf")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

medium: Consider adding a comment explaining why this specific version of protobuf is being used and if there are any known compatibility issues or benefits associated with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant