Open
Conversation
AlexAndBear
force-pushed
the
issues/1974
branch
4 times, most recently
from
fd7f960 to
31dff5b
Compare
JammingBen
reviewed
Mar 19, 2026
| } | ||
| </script> | ||
|
|
||
| <style> |
Member
There was a problem hiding this comment.
Can you scope this block? If not, please add it as CSS classes.
| @@ -0,0 +1,77 @@ | |||
| <template> | |||
| <div class="address-books-list px-1 flex flex-col"> | |||
| <app-loading-spinner v-if="isLoading" /> | |||
Member
There was a problem hiding this comment.
The AppLoadingSpinner should really only be used once per app per view because it has a static ID.
Suggested change
| <app-loading-spinner v-if="isLoading" /> | |
| <oc-spinner v-if="isLoading" :aria-label="$gettext('Loading address books')" /> |
# Conflicts: # pnpm-lock.yaml
AlexAndBear
force-pushed
the
issues/1974
branch
from
297a540 to
548ed95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes