Skip to content

fix: sidebar top margin too low when no FAB is present#2147

Merged
AlexAndBear merged 1 commit intomainfrom
fix-sidebar-margin
Mar 17, 2026
Merged

fix: sidebar top margin too low when no FAB is present#2147
AlexAndBear merged 1 commit intomainfrom
fix-sidebar-margin

Conversation

@AlexAndBear
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Mar 13, 2026
@github-project-automation github-project-automation bot moved this to Qualification in OpenCloud Team Board Mar 13, 2026
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Mar 13, 2026
@JammingBen
Copy link
Member

Hm I think it was just fine before, because it needs to align the the breadcrumbs. Now the breadcrumbs are sitting kinda in between the New button and the first nav item.

@AlexAndBear
Copy link
Member Author

AlexAndBear commented Mar 16, 2026

Hm I think it was just fine before, because it needs to align the the breadcrumbs. Now the breadcrumbs are sitting kinda in between the New button and the first nav item.

It wasn't that fine before

image

Where exactly do you make that observation? I can't find any view where we have the breadcrumbs but no FAB

@JammingBen
Copy link
Member

I was talking about the views with FAB, they seem to be affected by this change as well:

image

The ones without FAB do indeed look better, I haven't even checked that.

@kulmann
Copy link
Member

kulmann commented Mar 17, 2026

Screenshot 2026-03-17 at 09 30 10

we could also remove the padding top on the header above breadcrumbs... might also need to adjust the padding on the right then. can of worms, ugh.

@JammingBen
Copy link
Member

we could also remove the padding top on the header above breadcrumbs... might also need to adjust the padding on the right then. can of worms, ugh.

Yep I like it. But maybe rather increase the padding top to match the padding on the right/left? I think there could be a tiny bit more top padding in your screenshot.

@AlexAndBear AlexAndBear force-pushed the fix-sidebar-margin branch 3 times, most recently from 654b4db to 71a80f3 Compare March 17, 2026 10:33
@AlexAndBear AlexAndBear merged commit 3b2d43e into main Mar 17, 2026
1 check passed
@AlexAndBear AlexAndBear deleted the fix-sidebar-margin branch March 17, 2026 10:38
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenCloud Team Board Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants