Abort precheck if fuse is not available#837
Merged
TheOneRing merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
TheOneRing
force-pushed
the
work/check_for_fuse
branch
3 times, most recently
from
1a6ec63 to
a1d9bcf
Compare
TheOneRing
force-pushed
the
work/check_for_fuse
branch
from
a1d9bcf to
4388ac6
Compare
dragotin
requested changes
Mar 9, 2026
| if (QStandardPaths::findExecutable(u"fusermount3"_s).isEmpty()) { | ||
| qCWarning(lcVfsXAttr) << u"fusermount3 is not installed on the system"; | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Maybe add another check if the openvfsfuse binary is available and executable?
Contributor
Author
There was a problem hiding this comment.
Hmm the two here are system checks.
Fuse might not be available on the system.
openvfs is a mandatory dependency of opencloud.
We link the openvfs lib, so the plugin loading would already fail. If the executable is missing.... we would display an error later in the ui.
dragotin
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #839