Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/loadfor pristine saved sessions that have no turns yet and only need a fresh ACP sessionWhy
Issue #165 reports a large delay before the first streamed text event on
codex prompt --sessioncompared withcodex exec.For freshly ensured sessions with no prior turns,
acpxwas still attemptingsession/loadbefore the first prompt. On Codex, that extra resume path appears to be the wrong fit for a pristine session and can delay the first streamed output. This change sends those pristine sessions straight tosession/newinstead.Fixes #165.
Validation
pnpm run buildpnpm run build:testnode --test dist-test/test/connect-load.test.jsnode --test dist-test/test/prompt-runner.test.js