added Entity.visit(EntityVisitor) to navigate entity state#276
Merged
pdowler merged 2 commits intoopencadc:mainfrom Oct 23, 2025
Merged
added Entity.visit(EntityVisitor) to navigate entity state#276pdowler merged 2 commits intoopencadc:mainfrom
pdowler merged 2 commits intoopencadc:mainfrom
Conversation
add ConfigFileReader with lower level raw output than PropertiesReader
Member
Author
|
I might go back and rename some variable names to |
andamian
reviewed
Oct 23, 2025
| } | ||
|
|
||
| private class LogVisitor implements EntityVisitor { | ||
|
|
Contributor
There was a problem hiding this comment.
Is this just a "visual" test? Shouldn't it accumulate the visited elements which then can be tested against the expected list?
Member
Author
There was a problem hiding this comment.
I added some assertions about number of visits of each type... so doesn't check the exact visits (that is still visual) but a code change likely breaks the test
| } | ||
| } else if (isDataModelClass(cc)) { | ||
| // depth-first recursion | ||
| visitImpl(cc, co, ev); |
Member
Author
There was a problem hiding this comment.
hmm, I think in principle this us right. I will try to create a test and then add it.
andamian
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ConfigFileReader with lower level raw output than PropertiesReader