Skip to content

Remove external links to images#832

Open
JerryVincent wants to merge 3 commits intodevfrom
feat/removeExternalLinks
Open

Remove external links to images#832
JerryVincent wants to merge 3 commits intodevfrom
feat/removeExternalLinks

Conversation

@JerryVincent
Copy link
Collaborator

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Added the sensor and device images to the public folder and removed the links to the external sources.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@JerryVincent
Copy link
Collaborator Author

Still some images are missing though. The following sensor images are still missing:

  • DHT22 - Temperature, Humidity
  • BME280 - Pressure, Temperature, Humidity
  • WindSpeed
  • SHT3X - Temperature, rel. Luftfeuchte
  • PMS5003 - PM01, PM10, PM25
  • TSL45315 - Beleuchtungsstärke
  • BMP180 - Temperature
  • PMS7003- PM01, PM25, PM10
  • PMS1003 - PM01, PM25, PM10
  • PMS3003 - PM01, PM25, PM10
  • DNMS - Schalldruckpegel (Min)
  • DHT11 - rel. Luftfeuchte

@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.27% 1670 / 2343
🔵 Statements 69.58% 1741 / 2502
🔵 Functions 73.33% 341 / 465
🔵 Branches 58.14% 928 / 1596
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/utils/sensor-definitions.ts 100% 100% 100% 100%
Generated in workflow #2235 for commit c2d0b58 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove links to external imgs (e.g. sensebox) and replace by local asset

1 participant