Skip to content

Fix/simplify user profile name#816

Merged
scheidtdav merged 18 commits intodevfrom
fix/simplify-user-profile-name
Mar 17, 2026
Merged

Fix/simplify user profile name#816
scheidtdav merged 18 commits intodevfrom
fix/simplify-user-profile-name

Conversation

@jona159
Copy link
Contributor

@jona159 jona159 commented Mar 11, 2026

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@jona159 jona159 marked this pull request as ready for review March 11, 2026 14:27
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.27% 1670 / 2343
🔵 Statements 69.58% 1741 / 2502
🔵 Functions 73.33% 341 / 465
🔵 Branches 58.14% 928 / 1596
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/user-service.server.ts 86.33% 74.33% 85.71% 89.14% 100-104, 148-152, 291-293, 395-406, 419, 466-482, 499, 549, 550
app/lib/user-service.ts 92% 92% 100% 91.3% 66, 80
app/models/profile.server.ts 3.57% 0% 9.09% 4% 15-49, 71-105
app/models/user.server.ts 76.92% 83.33% 61.9% 76.92% 15-16, 29-40, 122-131, 191
app/routes/api.users.register.ts 66.66% 47.36% 100% 66.66% 16-18, 24, 29, 37, 68-81
app/schema/profile.ts 80% 100% 66.66% 75% 24
app/schema/user.ts 100% 100% 100% 100%
Generated in workflow #2223 for commit 0614a55 by the Vitest Coverage Report Action

@scheidtdav
Copy link
Member

@jona159 Typescript is still complaining about seed.ts, could you check please?

@scheidtdav scheidtdav enabled auto-merge (squash) March 17, 2026 10:45
@scheidtdav scheidtdav merged commit 39ace92 into dev Mar 17, 2026
6 checks passed
@scheidtdav scheidtdav deleted the fix/simplify-user-profile-name branch March 17, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplify (user)name in profile/ account

2 participants