Draft
Conversation
- Add new Available trait - Job now uses engine provided by get_engine function - Use crun for podman if available - Package crun for opensuse variants
- it's not implemented anyway
- use skopeo to copy image from registry to local directory - on image cleanup remove directory
- CRun::is_available now checks for it's dependencies which we do not need if used through podman
Instead of relying outside dep check, move this check to CRun::is_available. Also add some debug logging.
- when using skopeo we need transport prefix, if there is non, use docker:// as default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring of code to allow adding different container engines. Also in PR I add volume management outside of podman and skopeo support.
TODO:
Partly fixes #4