Improve diagram editor connection compatibility hints#182
Improve diagram editor connection compatibility hints#182ArizmendiWan wants to merge 8 commits intoopen-rmf:mainfrom
Conversation
Signed-off-by: ArizmendiWan <2311602492@qq.com>
a7faafc to
10abb27
Compare
|
Thanks for this contribution! The UI hints shown in the video look very impressive and helpful! Just one high level thought before conducting a full code review: a |
aaronchongth
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I've just left some high level review comments for now. Will get back to you soon with more a more in-depth review
Signed-off-by: ArizmendiWan <2311602492@qq.com>
ef7542e to
d10cd87
Compare
|
Thanks for your feedbacks! I have addressed the requested review changes:
demo_v01.movPlease let me know if there’s anything else you’d like me to adjust. |
Update the add-operation UI and connection hints for compatible previous and next operations, and keep the supporting drag-direction logic aligned with that flow. Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
|
Thanks for the review! I have addressed the remaining review comments:
demo_v02.mov |
Signed-off-by: ArizmendiWan <2311602492@qq.com>
|
I also updated the compatibility hint functionality. Right now it also checks if a handle is already full. If one handle is full, no compatibility will be shown and the hint panel will show corresponding messages. demo_v03.mov |
aaronchongth
left a comment
There was a problem hiding this comment.
Thanks for the added features and validations! The validations and connection restrictions make sense to me, and I didn't manage to trigger any edge cases so far, but I'll leave the final verdict to @mxgrey to see if anything comes to mind that may be an edge case.



This PR is an initial implementation for #172. It improves drag-time connection feedback and adds a compatibility-aware next-operation flow in the diagram editor.
Current changes include:
demo.mov
This PR also includes a small incidental frontend sync fix for a stale generated type/schema reference that was needed to keep the frontend building cleanly.
GenAI Use
Generated-by: Codex Version 26.309.31024 (962) and Claude Code v2.1.76.