Issue1478 Update TRV opening characteristic#1483
Open
annadellisola wants to merge 3 commits intomasterfrom
Open
Issue1478 Update TRV opening characteristic#1483annadellisola wants to merge 3 commits intomasterfrom
annadellisola wants to merge 3 commits intomasterfrom
Conversation
annadellisola
commented
Mar 31, 2026
Contributor
Author
There was a problem hiding this comment.
The change in the valve opening charcateristic results in a shift in time of the opening of the valves as visible in the picture below.
In the current formulation the valves will start closing when the T measured is equal to TSet-P/2. Therefore valSte.y and valDym.y is equal to 0.5 when the T measured is equal to the setpoint of 21°C.
annadellisola
commented
Mar 31, 2026
Contributor
Author
There was a problem hiding this comment.
As expected the temperatures in the different zones are mainly higher compared to previous reference, due to the change in the opening of the TRVs considering the TSet at the center of the bandwidth (instead of at the upper bound).
lucasverleyen
approved these changes
Mar 31, 2026
Member
|
Thanks a lot, @annadellisola, for addressing this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes issue #1478