Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Python environment by removing support for Python 3.9 and upgrading key development dependencies, most notably Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
===========================================
- Coverage 100.00% 95.67% -4.33%
===========================================
Files 2 30 +28
Lines 36 1455 +1419
===========================================
+ Hits 36 1392 +1356
- Misses 0 63 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.9, making 3.10 the new minimum required version. The changes primarily involve updating type hints to use the modern | syntax for unions, which has been applied consistently throughout the codebase. Additionally, pytest has been upgraded to version 9. I've identified a couple of critical issues related to an incorrect dependency version for pytest-asyncio and a faulty type alias definition that will need to be addressed. Otherwise, the changes look good.
This PR
pytestto v9, which was blocked by dropping Python 3.9 support 😅Related Issues
Relates open-feature/python-sdk#554
Notes
Don't merge it yet, I want to release some packages before automatically increasing the minor version