Skip to content

test(plugin): update report gating fixtures for new template sections#183

Merged
onlycastle merged 2 commits intomainfrom
test/update-report-gating-fixtures-20260323
Mar 23, 2026
Merged

test(plugin): update report gating fixtures for new template sections#183
onlycastle merged 2 commits intomainfrom
test/update-report-gating-fixtures-20260323

Conversation

@onlycastle
Copy link
Owner

Summary

  • Add missing stage output fixtures for extract domain skills (aiCollaboration, contextEngineering, toolMastery, burnoutRisk, aiControl, skillResilience) and content stage data
  • Update report gating test assertions to match refactored report template sections (Top Focus Areas, Personality Summary, Weekly Insights)

Changes

  1. test(plugin): add extract domain and content stage fixtures
  2. test(plugin): update report gating assertions for new template sections

Test Plan

  • Code compiles without errors (tsc --noEmit passes)
  • generate-report-gating.test.ts — 2/2 tests pass
  • Manual verification of changes

Generated with Claude Code using /ship-it

onlycastle and others added 2 commits March 23, 2026 00:06
Add missing stage output fixtures for extractAiCollaboration,
extractContextEngineering, extractToolMastery, extractBurnoutRisk,
extractAiControl, extractSkillResilience, and content stage data
to match the new domain skill pipeline from #181.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update HTML content assertions to match refactored report template:
- Planning Analysis → Top Focus Areas
- Critical Thinking → Personality Summary
- Anti-Patterns → Weekly Insights

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onlycastle
Copy link
Owner Author

onlycastle commented Mar 23, 2026

Code Review

Found 1 issue (pre-existing, not introduced by this PR but masked by it):

  1. Stale 'content' entry in REQUIRED_STAGE_NAMES blocks production report generation
    The write-content skill saves to stage "contentWriter", but REQUIRED_STAGE_NAMES still requires 'content' (line 28). The gate check will never see content as complete in production. The test fixture masks this by seeding both content and contentWriter keys.

Recommendation: Remove 'content' from REQUIRED_STAGE_NAMES in a follow-up PR. Also remove the dead content key from the test fixture — contentWriter already covers that data.


Generated with Claude Code

If useful, react with a thumbs-up. Otherwise, thumbs-down.

@onlycastle onlycastle merged commit c0039eb into main Mar 23, 2026
1 check passed
@onlycastle onlycastle deleted the test/update-report-gating-fixtures-20260323 branch March 23, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant