Merged
Conversation
clbarnes
approved these changes
Feb 16, 2026
lubianat
approved these changes
Feb 16, 2026
Contributor
lubianat
left a comment
lubianat
left a comment
There was a problem hiding this comment.
Oh, oops. Sorry for not catching that.
Besides a more thorough human reading, I wonder if an AI review could help catching those earlier
Contributor
|
I ran a post-mortem copilot review on #404, it flagged that https://github.com/ome/ngff/blob/main/.github/workflows/validation.yml is also commented out. maybe we can just remove the file? |
3 tasks
Contributor
Author
Jep. Validation now happens entirely over at ngff-spec. PS: I like the term post-mortem review 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #404
I just realized that I had uncommented the entirety of the review gh action in #404 while working on the PR, as it contained quite a few bs stuff - and forgot to re-activate it. The preview build is still there if one clicks on the readthedocs action at the bottom of the thread, but the comment in the conversation isn't.
This PR removes the bs build from the preview action and re-enables the gh previews. Relevant for #439!