Open
Conversation
While reading the stc internally in the fmr.py ResX and ResY were inverted (checked with stc.py)
…X_export_nifti.py
ofgulban
requested changes
May 20, 2025
Owner
ofgulban
left a comment
ofgulban
left a comment
There was a problem hiding this comment.
I think this change has been reverted to its original in newer BrainVoayger versions. Therefore, we might need to revert lines 245-245
Also, I think line 239 is redundant.
ofgulban
reviewed
May 20, 2025
Owner
ofgulban
left a comment
ofgulban
left a comment
There was a problem hiding this comment.
I think these changes to glm read and example script look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I modified the function glm.py to read GLM output file after RFX analysis. I added an example script in the wip folder.