Security: Terminal escape sequence injection via crafted app names#636
Closed
barttran2k wants to merge 2 commits intooffa:masterfrom
Closed
Conversation
In `ensure_sorted.py`, app names are extracted from `README.md` via regex and printed directly to the terminal interspersed with ANSI escape codes. If a malicious contributor inserts crafted escape sequences within app name fields in the Markdown (e.g., `[**\x1b]malicious\x1b\\**]`), they could potentially manipulate terminal output, hide malicious changes, or in some terminals execute commands. Affected files: ensure_sorted.py, index.html Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
In `ensure_sorted.py`, app names are extracted from `README.md` via regex and printed directly to the terminal interspersed with ANSI escape codes. If a malicious contributor inserts crafted escape sequences within app name fields in the Markdown (e.g., `[**\x1b]malicious\x1b\\**]`), they could potentially manipulate terminal output, hide malicious changes, or in some terminals execute commands. Affected files: ensure_sorted.py, index.html Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
offa
reviewed
Apr 7, 2026
Owner
|
Duplicate of #634. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ensure_sorted.py, app names are extracted fromREADME.mdvia regex and printed directly to the terminal interspersed with ANSI escape codes. If a malicious contributor inserts crafted escape sequences within app name fields in the Markdown (e.g.,[**\x1b]malicious\x1b\\**]), they could potentially manipulate terminal output, hide malicious changes, or in some terminals execute commands.Severity:
lowFile:
ensure_sorted.pySolution
Sanitize extracted app names before printing to the terminal by stripping or escaping non-printable and control characters, e.g.,
app_name = re.sub(r'[\x00-\x1f\x7f-\x9f]', '', app_name).Changes
ensure_sorted.py(modified)index.html(modified)Testing