feat(scan): warn on unusual change/receive derivation index#16
Open
feat(scan): warn on unusual change/receive derivation index#16
Conversation
Mitigates a ransom attack where a malicious coordinator crafts a PSBT with change at a non-hardened but extremely large index (e.g. m/.../1/2147483647). Script re-derivation still validates the output belongs to the user's key, but typical recovery wallets use a gap limit ~20 and would never rediscover the UTXO, effectively burning the funds. Display an inline red warning below any Receive or Change row whose address index exceeds UNUSUAL_DERIVATION_INDEX (10000), so the user can reject the signature before it is too late.
odudex
force-pushed
the
unusual_address_path
branch
from
a84eb78 to
b602cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #11
Mitigates a ransom attack where a malicious coordinator crafts a PSBT with change at a non-hardened but extremely large index (e.g. m/.../1/2147483647). Script re-derivation still validates the output belongs to the user's key, but typical recovery wallets use a gap limit ~20 and would never rediscover the UTXO, effectively burning the funds.
Display an inline red warning below any Receive or Change row whose address index exceeds UNUSUAL_DERIVATION_INDEX (10000), so the user can reject the signature before it is too late.