Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Remove remaining req/res params from BaseController + Auth.logout via SessionContext
Summary
Completes the
req, rescleanup started in v2.6.1.Auth.logout()now usesSessionContextinstead of accepting aSessionparameter.BaseControllerwrappers (logout,isLogged,getLoggedUser,hasRole,requireLogin) are now fully no-arg.WebServerupdated accordingly.Changes
1. Auth.logout() — uses SessionContext
Modified:
security/auth/Auth.javalogout(Session session)→logout()(no-arg)SessionContext.get().invalidate()with null guardimport SessionContext2. BaseController — all wrappers now no-arg
Modified:
http/controller/BaseController.javalogout(Session)→logout()— delegates toAuth.logout()isLogged(Request)→isLogged()getLoggedUser(Request)→getLoggedUser()hasRole(Request, String)→hasRole(String)requireLogin(Request, Response)→requireLogin()3. WebServer — updated calls
Modified:
core/WebServer.javaisLogged(req)→isLogged()getLoggedUser(req)→getLoggedUser()4. AuthTest — wired SessionContext
Modified:
AuthTest.javaimport SessionContexttearDown()now clearsSessionContextalongsideRequestContextlogout_invalidatesSession— setsSessionContext.set(session)before callingAuth.logout()logout_nullSession_doesNotThrow(no longer applicable — null guard is internal)Breaking Changes
Auth.logout(Session)→Auth.logout()(no-arg)BaseController.logout(Session)→BaseController.logout()(no-arg)BaseController.isLogged(Request)→BaseController.isLogged()BaseController.getLoggedUser(Request)→BaseController.getLoggedUser()BaseController.hasRole(Request, String)→BaseController.hasRole(String)BaseController.requireLogin(Request, Response)→BaseController.requireLogin()