Validate set index typeArgs and strip cloud settings in ObsessionDB#85
Merged
Validate set index typeArgs and strip cloud settings in ObsessionDB#85
Conversation
feat(plugin-obsessiondb): strip storage_policy from table settings for local dev docs: update skip index examples and documentation with typeArgs - SkipIndexDefinition now requires typeArgs for set, tokenbf_v1, ngrambf_v1 (type-level validation + runtime safety check) - ObsessionDB plugin strips cloud-only settings (storage_policy) during migration to standard ClickHouse - Fix index type parsing in ClickHouse introspection for proper narrowing - Update all docs and skill examples to include typeArgs: '0' for set indexes - Add 5 new tests for storage_policy stripping behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeArgsforset,tokenbf_v1,ngrambf_v1index types. Baresetwithout args is a compile error. Runtime validation provides a safety net for edge cases.storage_policyfrom table settings during migration to local ClickHouse (non-ObsessionDB targets), improving local development experience.typeArgsfor parameterized index types.Test plan
setwithouttypeArgsis caught by validation🤖 Generated with Claude Code