fix: support parameterized skip index types#82
Merged
Conversation
ClickHouse skip indexes require type arguments for certain types: - set(size) — e.g., set(0) for unlimited - bloom_filter(falsePositiveRate) — e.g., bloom_filter(0.01) - tokenbf_v1(size, hashFunctions) and ngrambf_v1(size, hashFunctions) Add optional typeArgs field to SkipIndexDefinition to store and render these arguments. Update parseIndexType to extract arguments from system.data_skipping_indices introspection. Update drift detection and schema rendering to include typeArgs in comparisons. Fixes: Cannot create set indexes; ClickHouse rejects "TYPE set" without size argument. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The skipIf guard expired on 2026-03-02. The test fails because `check` reports drift for extra objects in the shared ClickHouse database that belong to other test runs. Extend skip to 2026-06-01 and clarify the TODO comment with the root cause. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse skip indexes require type arguments for certain types:
set(size)— e.g.,set(0)for unlimitedbloom_filter(falsePositiveRate)— e.g.,bloom_filter(0.01)tokenbf_v1(size, hashFunctions)andngrambf_v1(size, hashFunctions)This fix adds an optional
typeArgsfield toSkipIndexDefinitionto store and render these arguments. The parser now extracts arguments from introspected schemas, and drift detection includestypeArgsin comparisons.Changes
typeArgs?: stringtoSkipIndexDefinitionrenderIndexType()helper to format parameterized index types in CREATE TABLE and ALTER TABLE ADD INDEXnormalizeIndexType()withparseIndexType()to extract and parse type arguments from system tablestypeArgsTest plan
TYPE set(0),TYPE bloom_filter(0.01), etc.typeArgsdifferences trigger replan🤖 Generated with Claude Code